[C3] Astro template dev bindings improvements #5072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 11bd57d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5072 +/- ##
==========================================
+ Coverage 70.33% 70.40% +0.06%
==========================================
Files 298 298
Lines 15515 15515
Branches 3987 3987
==========================================
+ Hits 10913 10923 +10
+ Misses 4602 4592 -10 |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8021565100/npm-package-wrangler-5072You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5072/npm-package-wrangler-5072Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8021565100/npm-package-wrangler-5072 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8021565100/npm-package-create-cloudflare-5072 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8021565100/npm-package-cloudflare-kv-asset-handler-5072npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8021565100/npm-package-miniflare-5072npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8021565100/npm-package-cloudflare-pages-shared-5072npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8021565100/npm-package-cloudflare-vitest-pool-workers-5072Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
dario-piotrowicz
approved these changes
Feb 22, 2024
dario-piotrowicz
approved these changes
Feb 22, 2024
petebacondarwin
approved these changes
Feb 23, 2024
jculvey
force-pushed
the
c3-astro-bindings-update
branch
from
e74ff4e to
11bd57d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR solves / how to test:
Updates the Astro template to improve bindings support in dev.
See also:
Author has addressed the following:
Issue(s)/PR(s): [Pages] Update Astro framework guide cloudflare-docs#13093
Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr reviewso future reviewers can take inspiration and learn from it.